Skip to content

*: add defer to logs the panic reason and stack (#6123)#6153

Merged
ti-chi-bot merged 1 commit intotikv:release-6.1from
ti-chi-bot:cherry-pick-6123-to-release-6.1
Mar 29, 2023
Merged

*: add defer to logs the panic reason and stack (#6123)#6153
ti-chi-bot merged 1 commit intotikv:release-6.1from
ti-chi-bot:cherry-pick-6123-to-release-6.1

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

@ti-chi-bot ti-chi-bot commented Mar 13, 2023

This is an automated cherry-pick of #6123

What problem does this PR solve?

Issue Number: Ref #6099

What is changed and how does it work?

add defer logs the panic reason and stack

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

None.

@ti-chi-bot
Copy link
Copy Markdown
Member Author

ti-chi-bot commented Mar 13, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Mar 13, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 13, 2023
Merged
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Mar 13, 2023
@ti-chi-bot ti-chi-bot requested review from JmPotato and disksing March 13, 2023 07:07
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Mar 29, 2023
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2023
@HuSharp
Copy link
Copy Markdown
Member

HuSharp commented Mar 29, 2023

/cherry-pick-invite

@ti-chi-bot
Copy link
Copy Markdown
Member Author

ti-chi-bot commented Mar 29, 2023

@HuSharp Please accept the invitation then you can push to the cherry-pick pull requests.
Comment with "/cherry-pick-invite" if the invitation is expired.
https://github.com/ti-chi-bot/pd/invitations

@HuSharp HuSharp force-pushed the cherry-pick-6123-to-release-6.1 branch from b0567e9 to ed745e2 Compare March 29, 2023 03:29
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2023
@HuSharp HuSharp force-pushed the cherry-pick-6123-to-release-6.1 branch from ed745e2 to dfd5b82 Compare March 29, 2023 03:30
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (39a4de6) 75.39% compared to head (a8648f1) 75.43%.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-6.1    #6153      +/-   ##
===============================================
+ Coverage        75.39%   75.43%   +0.04%     
===============================================
  Files              307      307              
  Lines            30493    30502       +9     
===============================================
+ Hits             22989    23008      +19     
- Misses            5496     5502       +6     
+ Partials          2008     1992      -16
Flag Coverage Δ
unittests 75.43% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cache/ttl.go 97.95% <100.00%> (+0.02%) ⬆️
pkg/systimemon/systimemon.go 100.00% <100.00%> (ø)
server/election/lease.go 84.50% <100.00%> (+0.44%) ⬆️
server/region_syncer/client.go 85.92% <100.00%> (+6.07%) ⬆️
server/tso/allocator_manager.go 63.07% <100.00%> (-0.49%) ⬇️
server/tso/global_allocator.go 62.76% <100.00%> (+0.19%) ⬆️

... and 22 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HuSharp
resolve conflict
a8648f1 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp force-pushed the cherry-pick-6123-to-release-6.1 branch from dfd5b82 to a8648f1 Compare March 29, 2023 04:54
@HuSharp
Copy link
Copy Markdown
Member

HuSharp commented Mar 29, 2023

@bufferflies @rleungx PTAL thx!

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 29, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 29, 2023
@rleungx
Copy link
Copy Markdown
Member

rleungx commented Mar 29, 2023

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member Author

ti-chi-bot commented Mar 29, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Copy Markdown
Member Author

ti-chi-bot commented Mar 29, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: a8648f1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 29, 2023
@ti-chi-bot ti-chi-bot merged commit d75733f into tikv:release-6.1 Mar 29, 2023
@HuSharp HuSharp deleted the cherry-pick-6123-to-release-6.1 branch March 29, 2023 06:18
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bufferflies bufferflies bufferflies approved these changes

@rleungx rleungx rleungx approved these changes

@disksing disksing Awaiting requested review from disksing

@JmPotato JmPotato Awaiting requested review from JmPotato

Assignees

No one assigned

Labels

cherry-pick-approved Cherry pick PR approved by release team. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ti-chi-bot @HuSharp @rleungx @bufferflies @VelocityLight
⚡